Skip to content

Add fix-only mode to greploop#22

Open
CINC0S wants to merge 2 commits into
greptileai:mainfrom
CINC0S:agent/issue-17-no-commit
Open

Add fix-only mode to greploop#22
CINC0S wants to merge 2 commits into
greptileai:mainfrom
CINC0S:agent/issue-17-no-commit

Conversation

@CINC0S

@CINC0S CINC0S commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add equivalent --no-commit and --fix-only inputs for a single local fix pass
  • preserve the existing index/worktree and leave all greploop edits unstaged, uncommitted, and unpushed
  • skip remote thread resolution and re-shelving in fix-only mode, then hand changed paths back to the user's publish workflow
  • pin GitHub, GitLab, and Perforce feedback to the reviewed head/version so a same-head pass cannot consume stale review results
  • document fix-only usage in the README

Fixes #17

Validation

  • parsed every Bash code block with bash -n after replacing documentation placeholders
  • exercised jq fixtures for first-strictly-newer review selection, exact check/pipeline/job pinning, current-head filtering, and review timestamps
  • verified both aliases, the one-pass stop, no-write guardrails, dual head checks, dirty-path tracking, default commit/push commands, README usage, and Perforce snapshot ordering
  • git diff --check
  • verified greploop/SKILL.md remains under 500 lines
  • commit-time Gitleaks hook passed

The skill-creator validator still reports the repository's pre-existing compatibility frontmatter key; the same error reproduces on the untouched baseline.

Review

A fresh independent review completed with no blocker or important findings and returned Approve.

Live GitHub, GitLab, and Perforce integration behavior was not exercised.

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds a single-pass fix-only mode to greploop. The main changes are:

  • Adds equivalent --no-commit and --fix-only inputs.
  • Preserves existing staged changes and leaves new fixes unstaged.
  • Skips commits, pushes, re-shelving, and remote thread resolution in fix-only mode.
  • Pins GitHub, GitLab, and Perforce feedback to the reviewed revision.
  • Improves GitLab pipeline selection, pagination, and discussion-state handling.
  • Documents the fix-only workflow in README.md.

Confidence Score: 5/5

This looks safe to merge.

The latest changes address the reported GitLab pipeline selection, pagination, and resolution-state failures. No blocking issues were found in the changed code.

T-Rex T-Rex Logs

What T-Rex did

  • The general-contract-validation-proof showed that, compared to the pre-feature baseline which lacked 12 of 13 changed safety assertions, the after-state passes all 13 structural safety assertions, parses 28 Bash blocks, and yields the expected IDs and filtered records from the jq fixtures.
  • Integrity validation confirmed the harness parses correctly, git diff --check passes, and the command exits with code 0.
  • Artifacts were collected to document the results, including the validation shell script and related logs.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
greploop/SKILL.md Adds fix-only workflow controls, revision-bound feedback collection, and GitLab review-selection fixes.
README.md Documents fix-only aliases, workspace behavior, and the manual publishing handoff.

Reviews (2): Last reviewed commit: "fix(greploop): address review feedback" | Re-trigger Greptile

Comment thread greploop/SKILL.md Outdated
Comment thread greploop/SKILL.md Outdated
Comment thread greploop/SKILL.md Outdated
Comment thread greploop/SKILL.md Outdated
@CINC0S

CINC0S commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

@greptile review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: --no-commit / fix-only mode for gstack workflow compatibility

1 participant